This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Strip debug info from docker_machine ip command #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
force-pushed
the
mwu/b0.22/win-idna-error
branch
from
30142ca to
1d345ef
Compare
mfranciszkiewicz
approved these changes
Dec 16, 2019
| ip = None | ||
| assert isinstance(raw_ip, str) | ||
| for line in raw_ip.splitlines(): | ||
| if line and line[0].isnumeric(): |
There was a problem hiding this comment.
The line[0].isnumeric() optimization is IMHO very output specific and not really needed here
There was a problem hiding this comment.
its a nitty speed improvement, was thinking its faster to check first if the first character is numeric, then parse the whole IP
Codecov Report
@@ Coverage Diff @@
## b0.22 #4995 +/- ##
==========================================
- Coverage 90.09% 90.09% -0.01%
==========================================
Files 233 233
Lines 21875 21886 +11
==========================================
+ Hits 19709 19718 +9
- Misses 2166 2168 +2 |
Wiezzel
approved these changes
Dec 16, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.