This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Prevent output paths from being nested on task restart #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etam
reviewed
Dec 20, 2019
|
@etam Agreed, working on it now. Probably should've marked this PR a draft, sorry about that. |
etam
reviewed
Dec 20, 2019
| client=self.client, | ||
| old_task_id=self.task_id, | ||
| task_dict=mock.ANY, | ||
| subtask_ids_to_copy={'finished-subtask-id'}, | ||
| ignore_gas_price=ignore_gas_price | ||
| ) | ||
|
|
||
| task_dict = restart_mock.call_args[1]['task_dict'] | ||
| output_path = task_dict['options']['output_path'] | ||
| self.assertEqual(output_path, task_output_path) |
There was a problem hiding this comment.
undeclared variable task_output_path?
There was a problem hiding this comment.
It's declared as top-level. I think the reason for this is to have a single test directory created for all tests from this file. If we were to change this then it could be moved into ProviderBase. This would result in each test class having a separate temp directory.
etam
reviewed
Dec 20, 2019
| @@ -764,6 +774,10 @@ def test_task_inactive(self, validate_funds_mock, restart_mock, *_): | |||
| ignore_gas_price=ignore_gas_price | |||
| ) | |||
|
|
|||
| task_dict = restart_mock.call_args[1]['task_dict'] | |||
| output_path = task_dict['options']['output_path'] | |||
| self.assertEqual(output_path, task_output_path) | |||
There was a problem hiding this comment.
undeclared variable task_output_path?
Codecov Report
@@ Coverage Diff @@
## b0.22 #5017 +/- ##
==========================================
+ Coverage 90.05% 90.08% +0.02%
==========================================
Files 234 234
Lines 21950 21954 +4
==========================================
+ Hits 19768 19777 +9
+ Misses 2182 2177 -5 |
jiivan
approved these changes
Dec 20, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4986