Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Handle task failure during creation #5060

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Handle task failure during creation #5060

merged 2 commits into from
Jan 22, 2020

Conversation

jiivan
Copy link
Contributor

@jiivan jiivan commented Jan 22, 2020

fixes: #4985

@jiivan jiivan force-pushed the b0.22-creationfail branch from 65df132 to f3552a7 Compare January 22, 2020 11:03
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #5060 into b0.22 will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            b0.22    #5060      +/-   ##
==========================================
- Coverage   90.05%   90.04%   -0.01%     
==========================================
  Files         234      234              
  Lines       22017    22016       -1     
==========================================
- Hits        19827    19825       -2     
- Misses       2190     2191       +1

@jiivan jiivan requested a review from kmazurek January 22, 2020 13:49
@jiivan jiivan marked this pull request as ready for review January 22, 2020 13:50
@jiivan jiivan requested a review from maaktweluit January 22, 2020 13:50
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Small nit about a maybe reserved keyword

@jiivan jiivan force-pushed the b0.22-creationfail branch from f3552a7 to 657d512 Compare January 22, 2020 14:19
@shadeofblue shadeofblue merged commit 22efdae into b0.22 Jan 22, 2020
@shadeofblue shadeofblue deleted the b0.22-creationfail branch January 22, 2020 18:03
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants