Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Follow symlinks for sys.executable #5078

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Conversation

maaktweluit
Copy link
Contributor

After the pyinstaller update to 3.6 the sys.executable no longer follows symlinks. Will make an issue on their side since the docs state it should.

from docs:

If the user launches the app by way of a symbolic link, sys.argv[0] uses that symbolic name, while sys.executable is the actual path to the executable. Sometimes the same app is linked under different names and is expected to behave differently depending on the name that is used to launch it. For this case, you would test os.path.basename(sys.argv[0])

@maaktweluit maaktweluit added P0 Severity-Critical/Effort-easy 0.22.1 release labels Jan 29, 2020
@maaktweluit maaktweluit self-assigned this Jan 29, 2020
Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wolfofwallstreet

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #5078 into b0.22 will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            b0.22    #5078      +/-   ##
==========================================
- Coverage   90.01%   89.99%   -0.02%     
==========================================
  Files         234      234              
  Lines       22022    22022              
==========================================
- Hits        19823    19819       -4     
- Misses       2199     2203       +4

@shadeofblue shadeofblue merged commit 771d7c7 into b0.22 Jan 29, 2020
@shadeofblue shadeofblue deleted the mwu/b0.22.1-fix-benchmark branch January 29, 2020 12:55
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
0.22.1 release P0 Severity-Critical/Effort-easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants