Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Use subtask timeout status in taskmanager #5136

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Conversation

kmazurek
Copy link
Contributor

@kmazurek kmazurek commented Mar 17, 2020

Part of: https://github.com/golemfactory/golem/pull/5136
Updates the legacy taskmanager to use SubtaskStatus.timeout instead of failure for subtasks which have timed out.

@kmazurek kmazurek self-assigned this Mar 17, 2020
@CLAassistant
Copy link

CLAassistant commented Mar 17, 2020

CLA assistant check
All committers have signed the CLA.

@kmazurek kmazurek requested review from jiivan and maaktweluit March 17, 2020 19:34
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #5136 into b0.23 will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            b0.23    #5136      +/-   ##
==========================================
+ Coverage   89.94%   89.98%   +0.04%     
==========================================
  Files         238      238              
  Lines       22438    22438              
==========================================
+ Hits        20182    20191       +9     
+ Misses       2256     2247       -9

Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmazurek kmazurek merged commit c76c673 into b0.23 Mar 19, 2020
@kmazurek kmazurek deleted the subtask-timeout-status branch March 19, 2020 09:58
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants