This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Set correct state when creating task with no funds #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When task creation fails due to insufficient funds, the task's state is now set to errorCreating. This commit also changes that state to be considered final.
Codecov Report
@@ Coverage Diff @@
## b0.23 #5137 +/- ##
=========================================
+ Coverage 89.9% 89.94% +0.03%
=========================================
Files 238 238
Lines 22438 22443 +5
=========================================
+ Hits 20174 20186 +12
+ Misses 2264 2257 -7 |
maaktweluit
pushed a commit
that referenced
this pull request
Mar 25, 2020
When task creation fails due to insufficient funds, the task's state is now set to errorCreating. This commit also changes that state to be considered final.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/golemfactory/golem/issues/5012
When task creation fails due to insufficient funds, the task's state is
now set to errorCreating. This commit also changes that state to be
considered final.