Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove resource_size from TaskHeader #319

Merged
merged 6 commits into from
Feb 28, 2019
Merged

Remove resource_size from TaskHeader #319

merged 6 commits into from
Feb 28, 2019

Conversation

badb
Copy link
Contributor

@badb badb commented Feb 13, 2019

If we want to make possible to add different resources for different subtasks we cannot send just one size in the TaskHeader. This PR:

  • Removes resource_size from TaskHeader
  • Removes providers check of resource size at the task selection state
  • Provider may refuse to compute tasks with too big resources after getting TaskToCompute with specific resource size.
  • Taskkeeper keeping time is updated after TaskToCompute with proper resource size is sent.

Golem PR: https://github.com/golemfactory/golem/pull/3917

@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #319 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          30       30           
  Lines        2126     2126           
=======================================
  Hits         2011     2011           
  Misses        115      115

@badb badb force-pushed the task_header_cleanup branch from be07c6c to ae707b0 Compare February 20, 2019 20:28
@badb badb force-pushed the task_header_cleanup branch from ae707b0 to 5cbe6f3 Compare February 24, 2019 15:47
@badb badb changed the title [WIP] Remove resource_size from TaskHeader Remove resource_size from TaskHeader Feb 24, 2019
@badb badb requested review from jiivan and shadeofblue February 24, 2019 20:32
Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cat straw drink

@badb badb merged commit 443572f into master Feb 28, 2019
@badb badb deleted the task_header_cleanup branch February 28, 2019 17:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants