Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FIX]: Sablier stream -- cancelled #648

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

jmikolajczyk
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk requested a review from aziolek February 14, 2025 08:28
@jmikolajczyk jmikolajczyk self-assigned this Feb 14, 2025
@housekeeper-bot housekeeper-bot temporarily deployed to uat February 14, 2025 08:31 Destroyed
Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmikolajczyk: shouldn't useAllSablierStreamsSum be adjusted too?

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Feb 14, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Feb 14, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #13328003763 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Feb 15, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Feb 15, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #13346469276 failed 💥

Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #13346469276 passed 🎉

@jmikolajczyk jmikolajczyk merged commit 9892c0f into develop Feb 17, 2025
47 checks passed
@jmikolajczyk jmikolajczyk deleted the fix/sablier-stream-cancelled branch February 17, 2025 12:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants