Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BUG] DoContext -> DoWithTimeout args convert error #575

Closed
Glacier759 opened this issue Oct 15, 2021 · 1 comment · Fixed by #576
Closed

[BUG] DoContext -> DoWithTimeout args convert error #575

Glacier759 opened this issue Oct 15, 2021 · 1 comment · Fixed by #576

Comments

@Glacier759
Copy link

redigo/redis/conn.go

Line 797 in 56d6448

r, e = c.DoWithTimeout(realTimeout, cmd, args)

maybe it should be like this：

r, e = c.DoWithTimeout(realTimeout, cmd, args...)
@Glacier759 Glacier759 changed the title [BUG] DoWithContext -> DoWithTimeout args convert error [BUG] DoContext -> DoWithTimeout args convert error Oct 15, 2021
stevenh added a commit that referenced this issue Oct 15, 2021
@stevenh
fix: DoContext call to DoWithTimeout
1097c8d 
Fix DoContext call to DoWithTimeout passing args as variadic.

Fixes #575
@stevenh stevenh mentioned this issue Oct 15, 2021
Merged
stevenh added a commit that referenced this issue Oct 15, 2021
@stevenh
fix: DoContext call to DoWithTimeout (#576)
574218b 
Fix DoContext call to DoWithTimeout passing args as variadic.

Fixes #575
@stevenh
Copy link
Collaborator

stevenh commented Oct 15, 2021

Thanks for the precise report @Glacier759!

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: DoContext call to DoWithTimeout gomodule/redigo
2 participants
@stevenh @Glacier759