feat: add Float64Map #605
Merged
feat: add Float64Map #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
requested changes
Mar 24, 2022
There was a problem hiding this comment.
Thanks for PR @zuoshuwen just a minor niggle, could you move this new method down to where the other map methods are, say after Int64Map around line 508 so that they are all together :)
stevenh
approved these changes
Mar 24, 2022
|
Hey @stevenh , thanks for your advice |
Co-authored-by: Steven Hartland <steven.hartland@multiplay.co.uk>
|
Thanks for taking this PR :) |
|
Thank you for the PR 🥇 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Float64Map()