Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

SimpleExoPlayerView doesn't apply aspect ratio if attached after playback has started #2077

Closed
ojw28 opened this issue Nov 16, 2016 · 1 comment
Closed

SimpleExoPlayerView doesn't apply aspect ratio if attached after playback has started #2077

ojw28 opened this issue Nov 16, 2016 · 1 comment
Assignees
@ojw28
Labels
bug

Comments

@ojw28
Copy link
Contributor

ojw28 commented Nov 16, 2016

See: #2068.
Also, on a related note, SimpleExoPlayerView should probably apply any unapplied rotation in the case that TextureView is being used.
@ojw28 ojw28 added the bug label Nov 16, 2016
@ojw28 ojw28 self-assigned this Nov 16, 2016
@ojw28 ojw28 mentioned this issue Nov 16, 2016
Closed
ojw28 added a commit that referenced this issue Nov 18, 2016
@ojw28
Make sure we report video size after Surface is set
61c9c16 
Issue: #2077

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=139451511
@ojw28
Copy link
Contributor Author

ojw28 commented Nov 18, 2016

I think this should be fixed in dev-v2 by the change ref'd above, although I didn't test this specific case. Please give it a try and let us know if there's still an issue!

@ojw28 ojw28 closed this as completed Nov 18, 2016
@google google locked and limited conversation to collaborators Jun 28, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@ojw28 ojw28

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ojw28