Make DrmSessionException constructor public to enable creating custom DrmSessionManager implementations. #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DrmSessionManager implementations.
|
Heh, this is an oversight. Thanks! We'll merge shortly. |
|
Anytime. :-) |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in the current dev-v2 branch it is not possible to implement a custom
DrmSessionManagerwhich implements theDrmSessioninterface in a reasonable way.The problem is that DrmSessionException has a package-local constructor, which means that the implementation of
DrmSession.onErrorcan't return anything other thannull(unless, of course, the implementation would be in the same package, likeDefaultDrmSessionManager).