Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support 7.1 EAC3 in MP4, DASH and HLS formats #3161

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

ybai001
Copy link
Contributor

@ybai001 ybai001 commented Aug 10, 2017

This update will provide below supports to ExoPlayer

  • MPEG-4 with 7.1-channel EAC3 playback
  • ID3v2 with 7.1-channel EAC3 playback, which used for HLS late binding
  • Parsing DASH manifest with Dolby specific element

@ybai001
Copy link
Contributor Author

ybai001 commented Aug 10, 2017

This new pull request is based on the discussion in pull request 3085. I removed the 7.1 EAC3 TS handling part.
And update code based on two ojw28's comments.

  1. file DashManifestParser.java: nit - Move this line(L909) to just above the switch statement (~L913)
  2. file DashManifestParser.java: line 908, using Util.toLowerInvariant instead

case "4000":
channels = 1;
break;
case "A000":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you're using toLowerInvariant on L908, these case constants also need to be lowercase :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm stupid. :)
Case constants are lowercase now.

@ojw28 ojw28 merged commit 2e95063 into google:dev-v2 Aug 11, 2017
@ybai001 ybai001 deleted the dev-v2-eac3-7.1 branch August 14, 2017 01:01
@google google locked and limited conversation to collaborators Dec 10, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants