-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Windows Appveyor builds are failing, but are showing green #689
Comments
The Appveyor build is red since https://ci.appveyor.com/project/google/benchmark/build/1401/job/2u8kwhb363sxvg7j anyway. |
It looks as if the build break (as opposed to the warnings) comes out of gmock, with an "no idea what warning 5046 is" error message. It doesn't really make sense that it suddenly appears at the point in the build history where it does, unless there's something about the build environment changing that Appveyor isn't showing me. Certainly it looks as if there has pretty much always been warnings in the Windows build (at least going back some time). I might try attacking some of those once/if I get the attribution paperwork in order. I've traced the C4512 warnings down to the State* const parent_ member on the StateIterator. Should that by any chance be a State const* ? |
…master branch. See google/googletest#1815 Fixes google#689.
…master branch. (#691) See google/googletest#1815 Fixes #689.
…master branch. (google#691) See google/googletest#1815 Fixes google#689.
VS2013 is unsupported since google#691 / google@eb8cbec but i forgot to update docs. References: * google#689 * google#691 * google/googletest#1815 * google#853 * google#854
Since 1b44120 the Windows Appveyor builds have been reporting warnings, but they are showing green since warnings aren't set to convert to errors, basically making the integration builds worthless.
The text was updated successfully, but these errors were encountered: