Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

host computer identification #722

Closed
peterlauro1973 opened this issue Nov 23, 2018 · 3 comments
Closed

host computer identification #722

peterlauro1973 opened this issue Nov 23, 2018 · 3 comments
Labels
enhancement good first issue help wanted

Comments

@peterlauro1973
Copy link

Would be possible to enhance benchmark output json file with an information about the host name on which the test was triggered?

just simple "uname -n" on Linux or "hostname" on windows.

This kind of information can be useful in situation when CI may trigger the benchmark tests on different hosts. The post-processing script can identify, select and compare the results not only based on cpu identification but also base the hostname.
@dmah42
Copy link
Member

dmah42 commented Nov 26, 2018

That sounds completely reasonable. Patches welcome :)

dmah42 pushed a commit that referenced this issue Dec 11, 2018
@jatinx @dominichamon
#722 Adding Host Name in Reporting (#733)
47a5f77 
* Adding Host Name and test

* Addressing Review Comments

* Adding Test for JSON Reporter

* Adding HOST_NAME_MAX for MacOS systems

* Adding Explaination for MacOS HOST_NAME_MAX Addition

* Addressing Peer Review Comments

* Adding codecvt in windows header guard

* Changing name SystemInfo and adding empty message incase host name fetch fails

* Adding Comment on Struct SystemInfo
@tesch1
Copy link
Contributor

tesch1 commented Apr 24, 2019

Closeable?

@LebedevRI
Copy link
Collaborator

Right, thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@LebedevRI @tesch1 @dmah42 @peterlauro1973