Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: added benchmark_counters_tabular for file #1645

Merged

Conversation

varshneydevansh
Copy link
Contributor

The basics

  • I branched from main
  • My pull request is against main
  • My code follows the Google Style Guide
  • I ran clang-format

The details

Resolves

Proposed Changes

--benchmark_counters_tabular=true flag should be correctly applied for the output files for the --benchmark_out_format=console

Behavior Before Change

------------------------------------------------------------------------------------
Benchmark                          Time             CPU   Iterations UserCounters...
------------------------------------------------------------------------------------
l4cp_a_c/32/manual_time      3349447 ns        74761 ns          209 flush=0.68267 items_per_second=298.557/s
l4cp_a_c/512/manual_time    20886315 ns        0.000 ns           34 flush=0.707233 items_per_second=47.8782/s
l4cp_a_f/32/manual_time        62964 ns        45752 ns        10587 flush=0.0637161 items_per_second=15.8821k/s
l4cp_a_f/512/manual_time      182277 ns        50457 ns         3716 flush=0.216913 items_per_second=5.48616k/s

Behavior After Change

------------------------------------------------------------------------------------
Benchmark                          Time             CPU   Iterations     flush  items_per_second
------------------------------------------------------------------------------------
l4cp_a_c/32/manual_time      3349447 ns        74761 ns          209   0.68267         298.557/s
l4cp_a_c/512/manual_time    20886315 ns        0.000 ns           34  0.707233         47.8782/s
l4cp_a_f/32/manual_time        62964 ns        45752 ns        10587 0.0637161        15.8821k/s
l4cp_a_f/512/manual_time      182277 ns        50457 ns         3716  0.216913        5.48616k/s

Reason for Changes

With the latest version, the below command line should be applied to the output file for the console option for a clear output.

$ ./bm --benchmark_out=result.txt --benchmark_out_format=console
--benchmark_counters_tabular=true

Test Coverage

I haven't tested this, as soon as I got confirmation that these are the required changes that will update the status of the Test Coverage.

Documentation

I do not think there is any need for the documentation changes/ update as it's a bug which is correcting the output for the files.

Additional Information

src/benchmark.cc Outdated Show resolved Hide resolved
@dmah42 dmah42 merged commit cbecc8f into google:main Aug 11, 2023
60 checks passed
@dmah42
Copy link
Member

dmah42 commented Aug 11, 2023

amazing. thank you!

@varshneydevansh varshneydevansh deleted the benchmark_counters_tabular_is_invalid_834 branch August 11, 2023 10:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--benchmark_counters_tabular is invalid for --benchmark_out
2 participants