-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Increase the kMaxIterations limit #1668
Conversation
This fixes google#1663. Note that as a result of this change, the columns in the console output can become misaligned if the actual iteration count is too high. This will be dealt with in a separate commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, thank you!
in the bazel windows run. |
approved, but there's more lint errors i think. |
It looks like the other lint error actually comes from this PR: #1681 I think it should be fixed there. |
that's been merged and didn't have a lint issue.. maybe try updating this branch to head? |
Actually, it looks like the other one does have this issue, even though it was merged: https://github.com/google/benchmark/actions/runs/6535161131/job/17744142279 |
oh woops. i thought i had lint set as a required CI. i'll fix that separately then. |
Oops... |
thank you! |
|
This pull request fixes #1663. Note that as a result of this change, the columns in the console output can become misaligned if the actual iteration count is too high. This will be dealt with separately (see also #1664).