Add Missing \n at the End of Error Log String
#1700
Conversation
Closes google#1699 Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -254,7 +254,7 @@ bool PerfCounters::IsCounterSupported(const std::string&) { return false; } | |||
| PerfCounters PerfCounters::Create( | |||
| const std::vector<std::string>& counter_names) { | |||
| if (!counter_names.empty()) { | |||
| GetErrorLogInstance() << "Performance counters not supported."; | |||
| GetErrorLogInstance() << "Performance counters not supported.\n"; | |||
There was a problem hiding this comment.
nit: std::endl is the C++ standard line ending output character.
There was a problem hiding this comment.
let me know if you want to change this or if i should just merge it.
There was a problem hiding this comment.
Just seeing this and I would just stick to \n to avoid a STDOUT flush, more @ https://en.cppreference.com/w/cpp/io/manip/endl.
|
decided we can live with the |
|
Thanks for the review and merge @dmah42 🥂 |
Closes #1699