Bump pre-commit dependencies #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmah42
reviewed
Jan 18, 2024
tools/gbench/util.py
Outdated
| @@ -131,7 +131,7 @@ def benchmark_wanted(benchmark): | |||
| if benchmark_filter is None: | |||
| return True | |||
| name = benchmark.get("run_name", None) or benchmark["name"] | |||
| if re.search(benchmark_filter, name): | |||
| if re.search(benchmark_filter, name) is not None: | |||
There was a problem hiding this comment.
how about just
return re.search(benchmark_filter, name) is not None
There was a problem hiding this comment.
Good call! Done in 6eece2b.
Also fix a mypy error in `tools.gbench.util` - the condition behaves the same as before, but in the new mypy version, the old condition results in an unreachable code error for the final `return False` statement. This is most likely a bug in mypy's reachability analysis, but the fix is easy enough here to circumvent it.
nicholasjng
force-pushed
the
dev-updates
branch
from
b30e5da to
6eece2b
Compare
dmah42
approved these changes
Jan 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
mypyto v1.8.0, andruffto v0.1.13.Also fix a mypy error in
tools.gbench.util- the condition behaves the same as before, but in the new mypy version, the old condition results in an unreachable code error for the finalreturn Falsestatement.This is most likely a bug in mypy's reachability analysis, but the fix is easy enough here to circumvent it.