[FR] Add API to provide custom profilers #1807 #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmah42
reviewed
Jul 2, 2024
dmah42
reviewed
Jul 2, 2024
|
looks like clang-format (style Google) needs to be run. |
xdje42
force-pushed
the
i1807-add-profile-api
branch
from
d292050 to
87be344
Compare
xdje42
force-pushed
the
i1807-add-profile-api
branch
from
87be344 to
df55243
Compare
dmah42
reviewed
Jul 12, 2024
This API is akin to the MemoryManager API and lets tools provide their own profiler which is wrapped in the same way MemoryManager is wrapped. Namely, the profiler provides Start/Stop methods that are called at the start/end of running the benchmark in a separate pass.
xdje42
force-pushed
the
i1807-add-profile-api
branch
from
df55243 to
c43d476
Compare
dmah42
approved these changes
Jul 16, 2024
dmah42
approved these changes
Jul 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is akin to the MemoryManager API and lets tools provide their own profiler which is wrapped in the same way MemoryManager is wrapped. Namely, the profiler provides Start/Stop methods that are called at the start/end of running the benchmark in a separate pass.