Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Supply MacOS deployment target to delocate, use build+uv frontend #1841

Closed
wants to merge 1 commit into from

Conversation

nicholasjng
Copy link
Contributor

This shaves off multiple minutes from the wheel builds alone.

Also revert to trusted publishing for wheel uploads as it is now set up.


This limits Google Benchmark PyPI distributions to Python 3.10+.

Successful wheel build run on this branch: https://github.com/nicholasjng/benchmark/actions/runs/10452277981 , slightly under 20 minutes elapsed time including aarch64.

This shaves off multiple minutes from the wheel builds alone.

Also revert to trusted publishing for wheel uploads as it is now set up.
@nicholasjng
Copy link
Contributor Author

Hm, I have no idea what's going wrong here - builds perfectly fine on my local laptop (MacOS ARM64). I will investigate.

@nicholasjng
Copy link
Contributor Author

nicholasjng commented Aug 20, 2024

Ah, it's related to the use of Python 3.11. The problem disappears when building with Python 3.12. I wonder if that's because of the removal of distutils?

EDIT: It's a failure in setuptools v73.0.0, which was released yesterday - that's why CI on main is green. Will update the requirements constraints asap.

@nicholasjng
Copy link
Contributor Author

Closing in favor of the follow-up PR containing the setuptools-scm revert, which is green.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants