-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
update standard to C++17 per C++ build support #1875
Conversation
this may not be necessary immediately as we're hitting google/googletest#4605. i might just disable the warning. |
actually, given we're like a month away from dropping support from C++14, maybe we can just pull up the schedule a bit and go all in on 17. |
I can reproduce the problem. |
@LebedevRI any concerns with pushing this a bit earlier than planned? |
@nicholasjng just flagging the 3.13 bindings on windows seem to be failing. |
Thanks for the info, I think it's related to the interaction of Bazel's Python windows toolchains and the stable ABI. The easiest fix is to just declare a 3.13 toolchain and revert the setup.py change. |
i think it's time. going for it. |
Nice! Maybe with the library itself moving to C++17 we could create a project-wide bazelrc hosting the most common build options - that could also shorten the Python bindings instructions. |
trying to update some packages for various platforms, googletest requires C++17 which means we now need it too.