Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update standard to C++17 per C++ build support #1875

Merged
merged 5 commits into from
Nov 13, 2024
Merged

update standard to C++17 per C++ build support #1875

merged 5 commits into from
Nov 13, 2024

Conversation

dmah42
Copy link
Member

@dmah42 dmah42 commented Nov 3, 2024

trying to update some packages for various platforms, googletest requires C++17 which means we now need it too.

@dmah42 dmah42 requested a review from LebedevRI November 3, 2024 18:42
@dmah42
Copy link
Member Author

dmah42 commented Nov 3, 2024

this may not be necessary immediately as we're hitting google/googletest#4605. i might just disable the warning.

@dmah42
Copy link
Member Author

dmah42 commented Nov 3, 2024

this may not be necessary immediately as we're hitting google/googletest#4605. i might just disable the warning.

actually, given we're like a month away from dropping support from C++14, maybe we can just pull up the schedule a bit and go all in on 17.

@Kataglyphis
Copy link

I can reproduce the problem.

@dmah42
Copy link
Member Author

dmah42 commented Nov 7, 2024

@LebedevRI any concerns with pushing this a bit earlier than planned?

@dmah42
Copy link
Member Author

dmah42 commented Nov 7, 2024

@nicholasjng just flagging the 3.13 bindings on windows seem to be failing.

@nicholasjng
Copy link
Contributor

Thanks for the info, I think it's related to the interaction of Bazel's Python windows toolchains and the stable ABI.

The easiest fix is to just declare a 3.13 toolchain and revert the setup.py change.

@dmah42
Copy link
Member Author

dmah42 commented Nov 13, 2024

i think it's time. going for it.

@dmah42 dmah42 merged commit 62a321d into main Nov 13, 2024
107 checks passed
@dmah42 dmah42 deleted the c++17 branch November 13, 2024 13:06
@nicholasjng
Copy link
Contributor

Nice! Maybe with the library itself moving to C++17 we could create a project-wide bazelrc hosting the most common build options - that could also shorten the Python bindings instructions.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants