Track two more details about runs - the aggregate name, and run name. #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to BaaMeow's work in google#616 but is not based on it. Two new fields are tracked, and dumped into JSON: * If the run is an aggregate, the aggregate's name is stored. It can be RMS, BigO, mean, median, stddev, or any custom stat name. * The aggregate-name-less run name is additionally stored. I.e. not some name of the benchmark function, but the actual name, but without the 'aggregate name' suffix. This way one can group/filter all the runs, and filter by the particular aggregate type. I *might* need this for further tooling improvement. Or maybe not. But this is certainly worthwhile for custom tooling.
|
❌ Build benchmark 1433 failed (commit a6af2ed1f6 by @LebedevRI) |
|
And this is why two build systems is a horrible idea. |
dmah42
reviewed
Sep 13, 2018
|
❌ Build benchmark 1434 failed (commit 583c4ef1b5 by @LebedevRI) |
dmah42
reviewed
Sep 13, 2018
src/complexity.cc
Outdated
| std::string benchmark_name = | ||
| reports[0].benchmark_name.substr(0, reports[0].benchmark_name.find('/')); | ||
|
|
||
| std::string benchmark_name = reports[0].benchmark_name().substr( |
There was a problem hiding this comment.
this should now be run_name right? at least, you assign it to run_name below.
There was a problem hiding this comment.
Hmm, right, sorry.
I think this run_name will be kinda broken for these range-based complexity measurements..
dmah42
approved these changes
Sep 13, 2018
|
Thank you for the review! |
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Dec 6, 2018
…google#675) This is related to @baameow's work in google#616 but is not based on it. Two new fields are tracked, and dumped into JSON: * If the run is an aggregate, the aggregate's name is stored. It can be RMS, BigO, mean, median, stddev, or any custom stat name. * The aggregate-name-less run name is additionally stored. I.e. not some name of the benchmark function, but the actual name, but without the 'aggregate name' suffix. This way one can group/filter all the runs, and filter by the particular aggregate type. I *might* need this for further tooling improvement. Or maybe not. But this is certainly worthwhile for custom tooling.
ghost
mentioned this pull request
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to @baameow's work in #616 but is not based on it.
Two new fields are tracked, and dumped into JSON:
It can be RMS, BigO, mean, median, stddev, or any custom stat name.
I.e. not some name of the benchmark function, but the actual
name, but without the 'aggregate name' suffix.
This way one can group/filter all the runs,
and filter by the particular aggregate type.
I might need this for further tooling improvement.
Or maybe not.
But this is certainly worthwhile for custom tooling.