Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handling promise rejection for sound.play() #157

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

moniika
Copy link
Contributor

@moniika moniika commented Dec 5, 2019

Prevents uncaught promise error on load of Pond game.
Based on google/blockly#2162

@moniika moniika requested a review from NeilFraser December 5, 2019 23:35
@NeilFraser NeilFraser merged commit 7f65e0e into google:master Dec 6, 2019
@moniika moniika deleted the audio-run-catch branch December 6, 2019 23:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants