Adding Blockly.utils.removeNode(..) #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...with Blockly.utils.removeNode(..), which includes a null/undefined check on parentNode before continuing.
rachel-fenichel
approved these changes
Sep 4, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#2040
Proposed Changes
Duplicate older removeNode behavior by copying
goog.dom.removeNode(..)into the Blockly codebase. Replaced all original locations ofgoog.dom.removeNode(..), not just the case for the existing error.Reason for Changes
The null check appears necessary, though the whole error case is not fully understood.
Test Coverage
I opened the BlockFactory locally, which crashed before making these changes.
Tested on: