Removing comment around <meta> #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bad commit during debugging.
AnmAtAnm
added
issue: bug
rachel-fenichel
approved these changes
Nov 14, 2018
|
Ignoring Travis, because it is trying to run generator tests, which don't work on Mac (and should have already been corrected). Stranger, it is running the test on master, which is no longer the base of this PR, and does not have generator tests. |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#2119
Proposed change
Remove comment around .
Reason for Changes
The tag fixes the page scale, and prevents the page from zooming. This keeps the toolbox on screen (can't pan the page if the workspace absorbs the scroll action) and keeps the touch points at reasonable scale.
Test Coverage
Rebuilt mobile demos and tested zoom behavior. The page scale starts correctly, and the page no longer zooms.
Tested on: