Improve typing #426

amitmarkel · 2023-12-19T17:02:38Z

No description provided.

…readonly.

tushuhei

Thanks for your PR!

javascript/src/parser.ts

…rmance." This reverts commit 9305a53.

amitmarkel · 2023-12-20T11:15:44Z

Done: Reverted the ifs that were added and added a comment about the negative score items.

amitmarkel added 3 commits December 19, 2023 18:56

Specify model type and mark it private and readonly.

1043b9f

Move the baseScope variable that is a constant to be class-level and …

228e297

…readonly.

Bail-out earlier on the score summation loop to improve performance.

9305a53

tushuhei self-requested a review December 19, 2023 21:24

tushuhei requested changes Dec 19, 2023

View reviewed changes

javascript/src/parser.ts Outdated Show resolved Hide resolved

amitmarkel changed the title ~~Improve typing and performance~~ Improve typing Dec 20, 2023

amitmarkel and others added 3 commits December 20, 2023 13:08

Merge branch 'google:main' into improve

25d73db

Revert "Bail-out earlier on the score summation loop to improve perfo…

ca6501b

…rmance." This reverts commit 9305a53.

Add comment that score items in models may be negative.

6e0f63e

amitmarkel requested a review from tushuhei December 20, 2023 11:15

tushuhei requested review from tushuhei and removed request for tushuhei December 20, 2023 13:00

tushuhei approved these changes Dec 20, 2023

View reviewed changes

tushuhei merged commit d2ca364 into google:main Dec 20, 2023

Provide feedback