Add type url parsing support

PiperOrigin-RevId: 603390969
google · Feb 1, 2024 · 0b425e3 · 0b425e3
1 parent 037b973
commit 0b425e3
Show file tree

Hide file tree

Showing 4 changed files with 59 additions and 0 deletions.
diff --git a/common/BUILD b/common/BUILD
@@ -38,6 +38,7 @@ cc_library(
     deps = [
         "//internal:strings",
         "@com_google_absl//absl/base:core_headers",
+        "@com_google_absl//absl/base:nullability",
         "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:cord",
     ],
@@ -49,6 +50,7 @@ cc_test(
     deps = [
         ":any",
         "//internal:testing",
+        "@com_google_absl//absl/strings:string_view",
     ],
 )
 

diff --git a/common/any.cc b/common/any.cc
@@ -16,6 +16,7 @@
 
 #include <string>
 
+#include "absl/base/nullability.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/string_view.h"
 #include "internal/strings.h"
@@ -37,4 +38,20 @@ std::string Any::DebugString() const {
                       "}");
 }
 
+bool ParseTypeUrl(absl::string_view type_url,
+                  absl::Nullable<absl::string_view*> prefix,
+                  absl::Nullable<absl::string_view*> type_name) {
+  auto pos = type_url.find_last_of('/');
+  if (pos == absl::string_view::npos || pos + 1 == type_url.size()) {
+    return false;
+  }
+  if (prefix) {
+    *prefix = type_url.substr(0, pos + 1);
+  }
+  if (type_name) {
+    *type_name = type_url.substr(pos + 1);
+  }
+  return true;
+}
+
 }  // namespace cel
diff --git a/common/any.h b/common/any.h
@@ -20,6 +20,7 @@
 #include <utility>
 
 #include "absl/base/attributes.h"
+#include "absl/base/nullability.h"
 #include "absl/strings/cord.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/string_view.h"
@@ -102,6 +103,17 @@ inline std::string MakeTypeUrl(absl::string_view type_name) {
   return MakeTypeUrlWithPrefix(kTypeGoogleApisComPrefix, type_name);
 }
 
+bool ParseTypeUrl(absl::string_view type_url,
+                  absl::Nullable<absl::string_view*> prefix,
+                  absl::Nullable<absl::string_view*> type_name);
+inline bool ParseTypeUrl(absl::string_view type_url,
+                         absl::Nullable<absl::string_view*> type_name) {
+  return ParseTypeUrl(type_url, nullptr, type_name);
+}
+inline bool ParseTypeUrl(absl::string_view type_url) {
+  return ParseTypeUrl(type_url, nullptr);
+}
+
 }  // namespace cel
 
 #endif  // THIRD_PARTY_CEL_CPP_COMMON_ANY_H_
diff --git a/common/any_test.cc b/common/any_test.cc
@@ -14,6 +14,7 @@
 
 #include "common/any.h"
 
+#include "absl/strings/string_view.h"
 #include "internal/testing.h"
 
 namespace cel {
@@ -28,5 +29,32 @@ TEST(MakeTypeUrl, Basic) {
   EXPECT_EQ(MakeTypeUrl("bar.Baz"), "type.googleapis.com/bar.Baz");
 }
 
+TEST(ParseTypeUrl, Valid) {
+  EXPECT_TRUE(ParseTypeUrl("type.googleapis.com/bar.Baz"));
+  EXPECT_FALSE(ParseTypeUrl("type.googleapis.com"));
+  EXPECT_FALSE(ParseTypeUrl("type.googleapis.com/"));
+  EXPECT_FALSE(ParseTypeUrl("type.googleapis.com/foo/"));
+}
+
+TEST(ParseTypeUrl, TypeName) {
+  absl::string_view type_name;
+  EXPECT_TRUE(ParseTypeUrl("type.googleapis.com/bar.Baz", &type_name));
+  EXPECT_EQ(type_name, "bar.Baz");
+  EXPECT_FALSE(ParseTypeUrl("type.googleapis.com", &type_name));
+  EXPECT_FALSE(ParseTypeUrl("type.googleapis.com/", &type_name));
+  EXPECT_FALSE(ParseTypeUrl("type.googleapis.com/foo/", &type_name));
+}
+
+TEST(ParseTypeUrl, PrefixAndTypeName) {
+  absl::string_view prefix;
+  absl::string_view type_name;
+  EXPECT_TRUE(ParseTypeUrl("type.googleapis.com/bar.Baz", &prefix, &type_name));
+  EXPECT_EQ(prefix, "type.googleapis.com/");
+  EXPECT_EQ(type_name, "bar.Baz");
+  EXPECT_FALSE(ParseTypeUrl("type.googleapis.com", &prefix, &type_name));
+  EXPECT_FALSE(ParseTypeUrl("type.googleapis.com/", &prefix, &type_name));
+  EXPECT_FALSE(ParseTypeUrl("type.googleapis.com/foo/", &prefix, &type_name));
+}
+
 }  // namespace
 }  // namespace cel