Fix bug in CreateListDirectStep which attempts to add unknowns to a…

… list PiperOrigin-RevId: 684461365
google · Oct 10, 2024 · c1dcb37 · c1dcb37
1 parent 11993ed
commit c1dcb37
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/eval/eval/create_list_step.cc b/eval/eval/create_list_step.cc
@@ -166,6 +166,13 @@ class CreateListDirectStep : public DirectExpressionStep {
         }
       }
 
+      if (!unknowns.IsEmpty()) {
+        // We found an unknown, there is no point in attempting to create a
+        // list. Instead iterate through the remaining elements and look for
+        // more unknowns.
+        continue;
+      }
+
       // Conditionally add if optional.
       if (optional_indices_.contains(static_cast<int32_t>(i))) {
         if (auto optional_arg =