Silence build warnings.

PiperOrigin-RevId: 658101862
google · Jul 31, 2024 · df7cc68 · df7cc68
1 parent 588cfad
commit df7cc68
Show file tree

Hide file tree

Showing 8 changed files with 48 additions and 4 deletions.
diff --git a/common/legacy_value.cc b/common/legacy_value.cc
@@ -80,6 +80,11 @@
 #define CEL_ATTRIBUTE_DEFAULT_VISIBILITY
 #endif
 
+#if defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wreturn-type-c-linkage"
+#endif
+
 namespace cel {
 
 namespace {
@@ -1652,3 +1657,7 @@ bool TestOnly_IsLegacyMapBuilder(const MapValueBuilder& builder) {
 }  // namespace interop_internal
 
 }  // namespace cel
+
+#if defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
diff --git a/common/map_type_reflector.cc b/common/map_type_reflector.cc
@@ -620,6 +620,11 @@ ABSL_CONST_INIT struct {
   LegacyTypeReflector_NewMapValueBuilder new_map_value_builder = nullptr;
 } legacy_type_reflector_vtable;
 
+#if defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wreturn-type-c-linkage"
+#endif
+
 #if ABSL_HAVE_ATTRIBUTE_WEAK
 extern "C" ABSL_ATTRIBUTE_WEAK absl::StatusOr<Unique<MapValueBuilder>>
 cel_common_internal_LegacyTypeReflector_NewMapValueBuilder(
@@ -643,6 +648,10 @@ void InitializeLegacyTypeReflector() {
   });
 }
 
+#if defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
+
 }  // namespace
 
 absl::StatusOr<Unique<MapValueBuilder>> TypeReflector::NewMapValueBuilder(

diff --git a/common/values/legacy_list_value.cc b/common/values/legacy_list_value.cc
@@ -37,6 +37,11 @@
 #include "internal/dynamic_loader.h"  // IWYU pragma: keep
 #include "internal/status_macros.h"
 
+#if defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wreturn-type-c-linkage"
+#endif
+
 namespace cel::common_internal {
 
 namespace {
@@ -247,3 +252,7 @@ absl::Status LegacyListValue::Contains(ValueManager& value_manager,
 }
 
 }  // namespace cel::common_internal
+
+#if defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
diff --git a/common/values/legacy_map_value.cc b/common/values/legacy_map_value.cc
@@ -37,6 +37,11 @@
 #include "internal/dynamic_loader.h"  // IWYU pragma: keep
 #include "internal/status_macros.h"
 
+#if defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wreturn-type-c-linkage"
+#endif
+
 namespace cel::common_internal {
 
 namespace {
@@ -267,3 +272,7 @@ absl::Status LegacyMapValue::Equal(ValueManager& value_manager,
 }
 
 }  // namespace cel::common_internal
+
+#if defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
diff --git a/common/values/legacy_struct_value.cc b/common/values/legacy_struct_value.cc
@@ -33,6 +33,11 @@
 #include "internal/status_macros.h"
 #include "runtime/runtime_options.h"
 
+#if defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wreturn-type-c-linkage"
+#endif
+
 namespace cel::common_internal {
 
 namespace {
@@ -318,3 +323,7 @@ absl::StatusOr<int> LegacyStructValue::Qualify(
 }
 
 }  // namespace cel::common_internal
+
+#if defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
diff --git a/eval/eval/cel_expression_flat_impl.h b/eval/eval/cel_expression_flat_impl.h
@@ -112,7 +112,7 @@ class CelExpressionRecursiveImpl : public CelExpression {
   CelExpressionRecursiveImpl& operator=(const CelExpressionRecursiveImpl&) =
       delete;
   CelExpressionRecursiveImpl(CelExpressionRecursiveImpl&&) = default;
-  CelExpressionRecursiveImpl& operator=(CelExpressionRecursiveImpl&&) = default;
+  CelExpressionRecursiveImpl& operator=(CelExpressionRecursiveImpl&&) = delete;
 
   // Implement CelExpression.
   std::unique_ptr<CelEvaluationState> InitializeState(

diff --git a/extensions/protobuf/type_reflector.cc b/extensions/protobuf/type_reflector.cc
@@ -392,8 +392,7 @@ class ProtoStructValueBuilder final : public StructValueBuilder {
                                                          value_factory_);
     CEL_RETURN_IF_ERROR(list_value->ForEach(
         value_manager,
-        [this, field, accessor,
-         &value_manager](const Value& element) -> absl::StatusOr<bool> {
+        [this, field, accessor](const Value& element) -> absl::StatusOr<bool> {
           CEL_RETURN_IF_ERROR((*accessor)(type_reflector_.descriptor_pool(),
                                           type_reflector_.message_factory(),
                                           reflection_, message_, field,

diff --git a/internal/new.cc b/internal/new.cc
@@ -41,7 +41,7 @@ namespace cel::internal {
 
 namespace {
 
-[[noreturn]] void ThrowStdBadAlloc() {
+[[noreturn, maybe_unused]] void ThrowStdBadAlloc() {
 #ifdef ABSL_HAVE_EXCEPTIONS
   throw std::bad_alloc();
 #else