Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove reference to handle factory #600

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Remove reference to handle factory #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions common/memory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,6 @@ class PoolingMemoryManagerVirtualDispatcher;
template <typename T>
class Allocator;

namespace base_internal {
template <typename T>
struct HandleFactory;
} // namespace base_internal

// `Shared` points to an object allocated in memory which is managed by a
// `MemoryManager`. The pointed to object is valid so long as the managing
// `MemoryManager` is alive and one or more valid `Shared` exist pointing to the
Expand Down Expand Up @@ -575,8 +570,6 @@ class PoolingMemoryManager {
friend struct NativeTypeTraits<PoolingMemoryManager>;
template <typename T>
friend class Allocator;
template <typename T>
friend struct base_internal::HandleFactory;

template <typename T>
static void DefaultDestructor(void* ptr) {
Expand Down Expand Up @@ -666,8 +659,6 @@ class PoolingMemoryManagerVirtualDispatcher final
friend struct CompositionTraits<MemoryManagerRef>;
template <typename T>
friend class Allocator;
template <typename T>
friend struct base_internal::HandleFactory;

explicit PoolingMemoryManagerVirtualDispatcher(
absl::Nonnull<const PoolingMemoryManagerVirtualTable*> vtable,
Expand Down Expand Up @@ -1100,8 +1091,6 @@ class ABSL_ATTRIBUTE_TRIVIAL_ABI MemoryManagerRef final {
friend struct CompositionTraits<MemoryManagerRef>;
template <typename T>
friend class Allocator;
template <typename T>
friend struct base_internal::HandleFactory;

explicit MemoryManagerRef(void* vpointer, void* pointer)
: vpointer_(vpointer), pointer_(pointer) {}
Expand Down