Fix nullability annotation of ReferenceCountingMemoryManager::Allocate().
#748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_637786972
branch
4 times, most recently
from
a8fb17d to
4f87c84
Compare
…te()`. The declaration didn't have an annotation; the definition is annotated as returning nonnull, but it contains a `return nullptr`. For the time being, I'm fixing this by removing the annotation on the definition (thereby making it consistent with the declaration). Code owners may want to follow up by marking both the definition and declaration as returning nullable if desired. PiperOrigin-RevId: 639685981
copybara-service
bot
force-pushed
the
test_637786972
branch
from
4f87c84 to
b10fc7f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nullability annotation of
ReferenceCountingMemoryManager::Allocate().The declaration didn't have an annotation; the definition is annotated as
returning nonnull, but it contains a
return nullptr.For the time being, I'm fixing this by removing the annotation on the definition
(thereby making it consistent with the declaration). Code owners may want to
follow up by marking both the definition and declaration as returning nullable
if desired.