Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

SourceFileTest.testSourceFileResolvesZipEntries failes for Windows #3206

Closed
lgemeinhardt opened this issue Jan 23, 2019 · 1 comment
Closed

SourceFileTest.testSourceFileResolvesZipEntries failes for Windows #3206

lgemeinhardt opened this issue Jan 23, 2019 · 1 comment
Labels
internal-issue-created An internal Google issue has been created to track this GitHub issue triage-done Has been reviewed by someone on triage rotation.

Comments

@lgemeinhardt
Copy link
Contributor

SourceFileTest.testSourceFileResolvesZipEntries failes for Windows

java.nio.file.NoSuchFileException: C:\Users\LGEMEI~1\AppData\Local\Temp\test4171789207027663828.js.zip!\foo.js
at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:79)
at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
at sun.nio.fs.WindowsFileSystemProvider.newByteChannel(WindowsFileSystemProvider.java:230)
at java.nio.file.Files.newByteChannel(Files.java:361)
at java.nio.file.Files.newByteChannel(Files.java:407)
at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384)
at java.nio.file.Files.newInputStream(Files.java:152)
at java.nio.file.Files.newBufferedReader(Files.java:2784)
at com.google.javascript.jscomp.SourceFile$OnDisk.getCodeReader(SourceFile.java:624)
at com.google.javascript.jscomp.SourceFile$OnDisk.getCode(SourceFile.java:602)
at com.google.javascript.jscomp.SourceFileTest.testSourceFileResolvesZipEntries(SourceFileTest.java:148)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:538)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:760)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:460)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:206)
lgemeinhardt added a commit to lgemeinhardt/closure-compiler that referenced this issue Jan 23, 2019
@lgemeinhardt
SourceFileTest.testSourceFileResolvesZipEntries failes for Windows go…
bbb67d5 
…ogle#3206

And fixes parts of "Support the workflow under Windows. google#9" (google/j2cl#9) from j2cl
@tjgq
Copy link
Contributor

tjgq commented Jan 23, 2019

Created Google internal issue b/123290150

@tjgq tjgq added triage-done Has been reviewed by someone on triage rotation. internal-issue-created An internal Google issue has been created to track this GitHub issue labels Jan 23, 2019
lgemeinhardt added a commit to lgemeinhardt/closure-compiler that referenced this issue Jan 23, 2019
@lgemeinhardt
SourceFileTest.testSourceFileResolvesZipEntries failes for Windows go…
0af946b 
…ogle#3206

And fixes parts of "Support the workflow under Windows. google#9"
(google/j2cl#9) from j2cl
lgemeinhardt added a commit to lgemeinhardt/closure-compiler that referenced this issue Jan 23, 2019
@lgemeinhardt
SourceFileTest.testSourceFileResolvesZipEntries failes for Windows go…
dad3b2b 
…ogle#3206

And fixes parts of "Support the workflow under Windows. google#9"
(google/j2cl#9) from j2cl
@tjgq tjgq closed this as completed in 4ac9af9 Jan 25, 2019
dtsengchromium pushed a commit to dtsengchromium/closure-compiler that referenced this issue Jan 28, 2019
@lgemeinhardt @dtsengchromium
Fix zip file entry resolution on Windows.
1ee1bf1 
See also google/j2cl#9.

Fixes google#3206.
Closes google#3207.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=230635801
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
internal-issue-created An internal Google issue has been created to track this GitHub issue triage-done Has been reviewed by someone on triage rotation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgemeinhardt @tjgq