[Dark-mode] Fixes for mobile #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to merge this now. Feedback is still welcome. |
|
Looks great, many thanks!
…On Sat, Apr 6, 2024 at 11:53 PM Patrice Chalin ***@***.***> wrote:
Merged #1917 <#1917> into main.
—
Reply to this email directly, view it on GitHub
<#1917 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6AU3N6EGNBHPX7PISXNYDY4BVG3AVCNFSM6AAAAABF2KMYHGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGM4DENJRHEYTOMY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview, e.g.: https://deploy-preview-1917--docsydocs.netlify.app/docs/
Screenshots
Before
Note the menu title text (which we don't want). Also the dropdown doesn't drop down, which is why the screenshot doesn't show the dropdown menu open:
After