Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add Indonesia (id) locale #1890

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Add Indonesia (id) locale #1890

merged 2 commits into from
Mar 2, 2021

Conversation

dwisiswant0
Copy link
Contributor

Fixes #

Proposed Changes

  • Add Indonesia (id) language

Release Note

 - Indonesia (id) language translation

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Mar 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Auto: added by CLA bot when any of the committers have not signed a CLA. label Mar 1, 2021
@google-oss-robot
Copy link

Hi @dwisiswant0. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dwisiswant0
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Mar 1, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Auto: added by CLA bot when all committers have signed a CLA. and removed cla: no Auto: added by CLA bot when any of the committers have not signed a CLA. labels Mar 1, 2021
@mikehelmick
Copy link
Contributor

Thanks for the contribution!

/ok-to-test
/hold

Checking on engagement with Indonesia.

sethvargo
sethvargo previously approved these changes Mar 1, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dwisiswant0, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sethvargo
Copy link
Member

/assign @mikehelmick

# ----------------

msgid "nav.issue-code"
msgstr "Kode masalah"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dwisiswant0 thank you for the PR. I think this translation might be incorrect. "Issue" is a verb in this case (synonyms: create, generate, make). I think this translation to "trouble".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(For all instances of "issue"). I'm not a native speaker though, so please correct me if I'm wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review this, looks like your context is correct. Should be resolved as per 63b4fee.

@sethvargo sethvargo merged commit c7c3237 into google:main Mar 2, 2021
@sethvargo
Copy link
Member

Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants