Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Caching for View-to-Parquet writes #1171

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

itsiggs
Copy link
Collaborator

@itsiggs itsiggs commented Aug 30, 2024

Description of what I changed

Quick refactoring to extend the cache implementation by @bashir2 to views for View-to-Parquet.

E2E test

TESTED:

Checklist: I completed these to help reviewers :)

  • I have read and will follow the review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review Java and Python style guides.

  • My IDE is configured to follow the Google code styles.

    No? Unsure? -> configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@itsiggs itsiggs requested review from bashir2 August 30, 2024 11:34
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.80%. Comparing base (4747017) to head (3bd5dfc).

Files with missing lines Patch % Lines
...in/java/com/google/fhir/analytics/ParquetUtil.java 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1171      +/-   ##
============================================
- Coverage     51.83%   51.80%   -0.03%     
  Complexity      710      710              
============================================
  Files            95       95              
  Lines          5834     5837       +3     
  Branches        772      773       +1     
============================================
  Hits           3024     3024              
- Misses         2520     2523       +3     
  Partials        290      290              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itsiggs for the quick fix.

@bashir2 bashir2 merged commit a833298 into google:master Aug 30, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants