Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Winky Rough: Version 1.205 added #9103

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emmamarichal
Copy link
Collaborator

@emmamarichal emmamarichal commented Feb 21, 2025

Taken from the upstream repo https://github.com/typofactur/winkyrough at commit typofactur/winkyrough@b72f2df.

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@emmamarichal emmamarichal added the -- Needs Upstream Resolution Upstream fix required before moving forward label Feb 21, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward I New Font
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

1 participant