Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update prompt in json_no_schema snippet #210

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Update prompt in json_no_schema snippet #210

merged 2 commits into from
Sep 12, 2024

Conversation

pcoet
Copy link
Contributor

@pcoet pcoet commented Sep 12, 2024

Make this match the other language snippets. Tested the change on my machine, and the output is as expected:

[{"recipeName": "Chocolate Chip Cookies"}, {"recipeName": "Peanut Butter Cookies"}, {"recipeName": "Oatmeal Raisin Cookies"}, {"recipeName": "Sugar Cookies"}, {"recipeName": "Snickerdoodles"}]

Make this match the other language snippets. Tested the change on my machine, and the output is as expected: 

`[{"recipeName": "Chocolate Chip Cookies"}, {"recipeName": "Peanut Butter Cookies"}, {"recipeName": "Oatmeal Raisin Cookies"}, {"recipeName": "Sugar Cookies"}, {"recipeName": "Snickerdoodles"}]`
Copy link
Member

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, but please also run go generate from this directory (samples).
It updates the documentation examples at pkg.go.dev

See the comment at the top of this file for more details

@pcoet
Copy link
Contributor Author

pcoet commented Sep 12, 2024

Done!

Copy link
Member

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eliben eliben merged commit 2ec7e23 into google:main Sep 12, 2024
2 checks passed
@pcoet pcoet deleted the patch-1 branch September 12, 2024 14:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants