-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove support for GHC < 9.0 #119
base: master
Are you sure you want to change the base?
Conversation
10a9e22
to
b73029d
Compare
Sorry we're still stuck with GHC 8.10 and I'd like to still keep it. But I don't work with Haskell anymore. @agrue What do you think? |
I don't think it matters to you. You can keep using the old version that's already imported in //third_party. Alternatively, if you want to be sure that we don't break it going forward and the new versions still work on 8.10, somebody should add this version to the build matrix. |
It's a bit scary, because this is a dependency of proto-lens. So if proto-lens eventually depends on a new version of ghc-source-gen that only works with GHC 9+, we won't be able to upgrade to that version. And unfortunately the "you can stay on the old version" logic doesn't apply there, because the proto ecosystem keeps evolving (e.g. we just recently had to add support for "proto editions" because proto files we depend on started using those features). So if we have to do a similar thing in the future, we'll be stuck unable to import the new proto-lens version with support for the new features. Unless we try to back-port those features onto the old internal version but... ugh. I don't know how to weigh this against the needs of external users though. If some other maintainer wants to merge this I don't feel like I can stop you. |
I have two points to offer here:
I don't feel strongly enough to advocate for this really. This PR can simply stay open until something changes... |
That makes sense to me. Okay, well if you ever do feel strongly about it, I can't really argue against it. |
Remove conditional source code for ghc < 9.0