-
Notifications
You must be signed in to change notification settings - Fork 30
Add GHC 9 support to CI #87
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Very cool, thanks @AriFordsham for building up our CI. It reports some of the builds aren't quite healthy yet :) |
@googlebot I consent. |
Now passing CI. |
@jinwoo @blackgnezdo can this be merged? |
Sorry I don't think I have enough knowledge on this package to review this PR completely. As all the checks passed, this is probably fine. @blackgnezdo , @judah if you guys think this is good, I'm fine with merging. If I don't hear any responses in 2-3 days, I'll merge this. |
@AriFordsham would you mind rewriting your commits so that they are all squashed together? I doubt there's much value in preserving this part of history. I also don't want to squash your and @mithrandi's commit together which is the only other alternative in the UI |
@mithrandi I believe your two commits would also benefit from either getting squashed or having a more detailed description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some superficial comments since I don't deeply understand the package.
ee1f041
to
6c7951a
Compare
All done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mithrandi once you squash your two changes we should be good to go.
I think I need @AriFordsham to squash them for me (no write access to this branch). |
@mithrandi If you squash them on your branch at https://github.com/mithrandi/ghc-source-gen/tree/ghc9 I can pull them in. I wouldn't want you to lose the attribution. |
Done! |
Ready to roll. |
Thank you @mithrandi and @AriFordsham! This was an example of awesome open source collaboration! |
Based on https://github.com/mithrandi/ghc-source-gen/tree/ghc9, should be fully working.