Skip to content

Add GHC 9 support to CI #87

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Add GHC 9 support to CI #87

merged 2 commits into from
Aug 12, 2021

Conversation

AriFordsham
Copy link
Contributor

@google-cla
Copy link

google-cla bot commented Aug 5, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@AriFordsham
Copy link
Contributor Author

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@mithrandi

@google-cla
Copy link

google-cla bot commented Aug 5, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@blackgnezdo
Copy link
Contributor

Very cool, thanks @AriFordsham for building up our CI. It reports some of the builds aren't quite healthy yet :)

@blackgnezdo blackgnezdo changed the title GHC 9 support Add GHC 9 support to CI Aug 5, 2021
@mithrandi
Copy link
Contributor

@googlebot I consent.

@AriFordsham
Copy link
Contributor Author

Now passing CI.

@AriFordsham
Copy link
Contributor Author

@jinwoo @blackgnezdo can this be merged?

@jinwoo
Copy link
Member

jinwoo commented Aug 9, 2021

Sorry I don't think I have enough knowledge on this package to review this PR completely. As all the checks passed, this is probably fine. @blackgnezdo , @judah if you guys think this is good, I'm fine with merging. If I don't hear any responses in 2-3 days, I'll merge this.

@AriFordsham
Copy link
Contributor Author

#77

@blackgnezdo
Copy link
Contributor

@AriFordsham would you mind rewriting your commits so that they are all squashed together? I doubt there's much value in preserving this part of history. I also don't want to squash your and @mithrandi's commit together which is the only other alternative in the UI

@blackgnezdo
Copy link
Contributor

@mithrandi I believe your two commits would also benefit from either getting squashed or having a more detailed description.

@blackgnezdo blackgnezdo requested a review from judah August 11, 2021 01:24
Copy link
Contributor

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some superficial comments since I don't deeply understand the package.

@AriFordsham AriFordsham force-pushed the ghc9 branch 5 times, most recently from ee1f041 to 6c7951a Compare August 11, 2021 13:13
@AriFordsham
Copy link
Contributor Author

All done.

@blackgnezdo blackgnezdo self-requested a review August 11, 2021 17:03
Copy link
Contributor

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mithrandi once you squash your two changes we should be good to go.

@blackgnezdo blackgnezdo removed the request for review from judah August 11, 2021 17:12
@mithrandi
Copy link
Contributor

I think I need @AriFordsham to squash them for me (no write access to this branch).

@AriFordsham
Copy link
Contributor Author

@mithrandi If you squash them on your branch at https://github.com/mithrandi/ghc-source-gen/tree/ghc9 I can pull them in. I wouldn't want you to lose the attribution.

@mithrandi
Copy link
Contributor

Done!

@AriFordsham
Copy link
Contributor Author

Ready to roll.

@blackgnezdo blackgnezdo merged commit 74089dd into google:master Aug 12, 2021
@blackgnezdo
Copy link
Contributor

Thank you @mithrandi and @AriFordsham! This was an example of awesome open source collaboration!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants