Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Failed cluster discovery was not returning an error #104

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

mikouaj
Copy link
Member

@mikouaj mikouaj commented Jul 25, 2022

Lack of error on return resulted i.e. in a green Cloud Run job on failure

Copy link
Member

@ewojtach ewojtach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikouaj mikouaj merged commit ca5cffc into main Jul 25, 2022
@mikouaj mikouaj deleted the failed-discovery-noErr-fix branch July 25, 2022 14:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants