Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Terraform improvements #111

Merged
merged 17 commits into from
Aug 5, 2022
Merged

Terraform improvements #111

merged 17 commits into from
Aug 5, 2022

Conversation

mikouaj
Copy link
Member

@mikouaj mikouaj commented Jul 29, 2022

Converted Terraform code into dynamic solution

  • Provisioning of resources needed for discovery is configurable with a dynamic block
  • Provisioning of resources needed for different output is configurable with the dynamic blocks
  • Introduced bash script to automate manual steps needed for Artifact Registry and Cloud Rub configuration.
  • Added infra diagram and updated README with inputs and outputs

ewojtach
ewojtach reviewed Aug 1, 2022
View reviewed changes
terraform/README.md Outdated Show resolved Hide resolved
ewojtach
ewojtach reviewed Aug 1, 2022
View reviewed changes
terraform/README.md Outdated Show resolved Hide resolved
ewojtach
ewojtach reviewed Aug 5, 2022
View reviewed changes
terraform/README.md Outdated Show resolved Hide resolved
ewojtach
ewojtach reviewed Aug 5, 2022
View reviewed changes
terraform/README.md Outdated Show resolved Hide resolved
ewojtach
ewojtach reviewed Aug 5, 2022
View reviewed changes
terraform/README.md Outdated Show resolved Hide resolved
ewojtach
ewojtach approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@ewojtach ewojtach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikouaj mikouaj merged commit 4e7e91c into main Aug 5, 2022
@mikouaj mikouaj deleted the tf-improvements branch August 5, 2022 11:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ewojtach ewojtach ewojtach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikouaj @ewojtach