Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: supports unicode paths #1069

Conversation

xfc1939
Copy link

@xfc1939 xfc1939 commented Jan 27, 2024

solved the questions about #998

@xfc1939 xfc1939 force-pushed the feature/support_unicode_paths_with_template branch from 1b873aa to 721bcf4 Compare January 27, 2024 16:14
@xfc1939
Copy link
Author

xfc1939 commented Jan 29, 2024

I used a marco that named GLOG_DEFINE_wstring in flags.cc, this marco defined in commandlineflags.h.
It‘s ok on CMake, but it's failed on bazel. because it's used gflags/gflags.h on bazel.
Have anyone give me a solution?

@sergiud
Copy link
Collaborator

sergiud commented Jan 29, 2024

Please do not create multiple PRs for the same issue because the comments are lost.

Let's continue in #998 where we left off.

@sergiud sergiud closed this Jan 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants