Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add LWP id to dump info #1146

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Add LWP id to dump info #1146

merged 1 commit into from
Feb 16, 2025

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Dec 19, 2024

LWP can help gdb find the corresponding thread more quickly.

*** SIGSEGV (@0xff) received by PID 2699683 (TID 0x7f342020a640 LWP 2700477) from PID 255; stack trace: ***
    @     0x7f3501070ee8 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x99ee7)

@stdpain stdpain force-pushed the dump_lwp_id branch 2 times, most recently from b0353d2 to 1e7279d Compare December 19, 2024 05:14
Copy link
Collaborator

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and apologies for the late reply.

Please see my remarks.

@stdpain stdpain requested a review from sergiud January 21, 2025 12:42
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.14%. Comparing base (ca390c4) to head (ba6dcc7).

Files with missing lines Patch % Lines
src/signalhandler.cc 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
- Coverage   62.22%   62.14%   -0.09%     
==========================================
  Files          19       19              
  Lines        2324     2327       +3     
  Branches      845      846       +1     
==========================================
  Hits         1446     1446              
- Misses        596      599       +3     
  Partials      282      282              
Files with missing lines Coverage Δ
src/signalhandler.cc 11.26% <0.00%> (-0.25%) ⬇️

LWP can help identifying the corresponding thread in a debugger more easily.
@sergiud
Copy link
Collaborator

sergiud commented Feb 16, 2025

Thanks!

@sergiud sergiud merged commit 7fcf58a into google:master Feb 16, 2025
132 of 136 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants