Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: use codecov token #752

Merged
merged 1 commit into from
Dec 7, 2021
Merged

ci: use codecov token #752

merged 1 commit into from
Dec 7, 2021

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Dec 6, 2021

@drigz It looks like we do need to set the upload token (CODECOV_TOKEN) because coverage uploads sometimes fail despite previously successful builds:

[2021-12-06T20:25:06.918Z] ['verbose'] The error stack is: Error: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 404 - Not Found - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

The token can be added in repository Settings -> Secrets -> Repository secrets. The token can be obtained from codecov.

Codecov settings also mention that "Github Integration is installed. However, this repository is not enabled." Thus, glog needs to be whitelisted by following the link on the page which I don't have access to.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #752 (a9a9e1e) into master (f4dd77a) will increase coverage by 1.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
+ Coverage   71.38%   72.65%   +1.27%     
==========================================
  Files          17       17              
  Lines        3208     3211       +3     
==========================================
+ Hits         2290     2333      +43     
+ Misses        918      878      -40     
Impacted Files Coverage Δ
src/logging.cc 73.68% <0.00%> (+0.92%) ⬆️
src/symbolize.cc 62.82% <0.00%> (+1.72%) ⬆️
src/glog/logging.h.in 82.27% <0.00%> (+4.64%) ⬆️
src/utilities.cc 67.64% <0.00%> (+13.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9b2f1...a9a9e1e. Read the comment docs.

@drigz
Copy link
Member

drigz commented Dec 7, 2021

I've set the repository secret. However, I also lack access to that page. If the problem persists, let me know and I can try to seek out a suitable admin.

@sergiud
Copy link
Collaborator Author

sergiud commented Dec 7, 2021

Thanks!

@sergiud sergiud merged commit ee6faf1 into master Dec 7, 2021
@sergiud sergiud deleted the codecov-token branch December 7, 2021 09:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants