Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(Yet another) heads up: Stricter validation coming soon to the create organization hook endpoint #1015

Closed
kytrinyx opened this issue Sep 23, 2018 · 3 comments
Assignees

Comments

@kytrinyx
Copy link
Contributor

We're working on adding stricter validation in the GitHub REST API, and uncovering all sorts of goodies and inconsistencies. ✨

In the Create organization hook endpoint we noticed the following errors come through with the google/go-github user agent:

'"created_at", "updated_at" are not permitted keys.'

Would you have a moment to check if this is encoded into the library, or whether this is a user error, as seen in #992 ?

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 23, 2018

Yes, same situation as #992 and #1014.
We use a full Hook struct that has these fields which means the user is able to populate it.
Once again, I think the solution in #997 is the best way to handle this.

@kytrinyx
Copy link
Contributor Author

Yes--I can't act as a tie breaker in the discussion, but I think that the arguments you list in #997 (comment) are a propos.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 25, 2018

I will let this sit possibly for a little while... although I'm tempted to just go in and fix it... but if a new Go developer or new contributor to this repo wants to take it, please comment and it is yours. (I've been accused of "nibbling the cookies" and robbing others of the opportunity to contribute in the past, so I'm trying not to do that. 😄)

Please read our CONTRIBUTING.md file for helpful information on contributing to this repo.

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants