Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refs should not encode / #1432

Closed
vetinari opened this issue Feb 17, 2020 · 0 comments · Fixed by #1433
Closed

Refs should not encode / #1432

vetinari opened this issue Feb 17, 2020 · 0 comments · Fixed by #1433

Comments

@vetinari
Copy link
Contributor

vetinari commented Feb 17, 2020 •
edited
Loading

The commit #1099 changed the ref name to be URL Query encoded. This breaks ref names which contain a /:

A call to curl -vH "Authorization: Bearer $TOKEN" https://$GHE_URL/repos/o/r/git/ref/heads/master works, but https://$GHE_URL/repos/o/r/git/ref/heads%2Fmaster (like GetRef(), GetRefs() use it) fail with 404.
vetinari added a commit to vetinari/go-github that referenced this issue Feb 17, 2020
@vetinari
do not encode / in ref names
4989112 
fixes google#1432

Signed-off-by: Hanno Hecker <hanno@zalando.de>
@vetinari vetinari mentioned this issue Feb 17, 2020
Merged
gmlewis pushed a commit that referenced this issue Feb 22, 2020
@vetinari
Do not encode / in ref names (#1433)
cb1e3f4 
Fixes: #1432.
n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
@vetinari
Do not encode / in ref names (google#1433)
110e42f 
Fixes: google#1432.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not encode / in ref names vetinari/go-github
1 participant
@vetinari