Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add MergedAt field to PullRequestLinks #3052

Closed
tatsuhiro-t opened this issue Jan 17, 2024 · 0 comments · Fixed by #3053
Closed

Add MergedAt field to PullRequestLinks #3052

tatsuhiro-t opened this issue Jan 17, 2024 · 0 comments · Fixed by #3053

Comments

@tatsuhiro-t
Copy link
Contributor

Please add MergedAt field to PullRequestLinks.
github upstream schema now has merged_at field:

      "pull_request": {
        "type": "object",
        "properties": {
          "merged_at": {
            "type": [
              "string",
              "null"
            ],
            "format": "date-time"
          },
          ...

Primary use case for this field is to know whether closed pull request is merged or not if API response returns Issues rather than PullRequests (e.g., search API).

tatsuhiro-t added a commit to zlabjp/go-github that referenced this issue Jan 17, 2024
gmlewis pushed a commit that referenced this issue Jan 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant