Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Visibility to UserEmail #1215

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Add Visibility to UserEmail #1215

merged 2 commits into from
Jul 4, 2019

Conversation

izumin5210
Copy link
Contributor

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 4, 2019
gmlewis
gmlewis requested changes Jul 4, 2019
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @izumin5210!

Please run the go generate ./... step found in our CONTRIBUTING.md document and then the build should pass.

@izumin5210
Copy link
Contributor Author

oh sorry... 🙈 i fixed it!

@codecov
Copy link

codecov bot commented Jul 4, 2019 •
edited
Loading

Codecov Report

Merging #1215 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1215   +/-   ##
=======================================
  Coverage   73.39%   73.39%           
=======================================
  Files          84       84           
  Lines        5949     5949           
=======================================
  Hits         4366     4366           
  Misses        825      825           
  Partials      758      758
Impacted Files Coverage Δ
github/users_emails.go 58.62% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ffc27d...c775ea8. Read the comment docs.

gmlewis
gmlewis approved these changes Jul 4, 2019
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @izumin5210!

LGTM. Merging.

@gmlewis gmlewis merged commit 7ce0678 into google:master Jul 4, 2019
@izumin5210 izumin5210 deleted the email-visibility branch July 4, 2019 13:04
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@izumin5210 @gmlewis
Add Visibility to UserEmail (google#1215)
837b0e0
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izumin5210 @gmlewis @googlebot