Skip to content

Update anchor with GitHub API docs in annotation #1475

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

3ks
Copy link
Contributor

@3ks 3ks commented Mar 28, 2020

Hi,

I found a very small problem when using go-github.

https://developer.github.com/v3/issues/#list-issues-for-a-repository is exists, but the anchor point (#list-issues-for-a-repository) is invalid.

I try to find the correct anchor point (#list-repository-issues) and update the corresponding content of the annotation.

This is a sacred moment for me! Please check it.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Mar 28, 2020
@3ks 3ks changed the title update anchor with GitHub API docs in annotation Update anchor with GitHub API docs in annotation Mar 28, 2020
@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #1475 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1475   +/-   ##
=======================================
  Coverage   68.15%   68.15%           
=======================================
  Files          94       94           
  Lines        8417     8417           
=======================================
  Hits         5737     5737           
  Misses       1819     1819           
  Partials      861      861           
Impacted Files Coverage Δ
github/issues.go 75.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c03e8...3b66a1e. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautifully done, @gorda ! Thank you!
LGTM.
Merging.

@gmlewis gmlewis merged commit 34cb1d6 into google:master Mar 28, 2020
Jeeejeets pushed a commit to Jeeejeets/go-github that referenced this pull request Apr 7, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants